Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing invalid function from compatibilityLAyer #655

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

wender
Copy link
Contributor

@wender wender commented Feb 21, 2024

What problem is this solving?

This function tries to set a read-only property with a piece of information that is already provided.

How to test it?

Try using tablet mode

Screenshots or example usage:

image image

Describe alternatives you've considered, if any.

Spreading the facet stops the error but is still useless since the function doesn't make any difference.

@wender wender requested review from a team as code owners February 21, 2024 22:01
@wender wender requested review from gvc, hellofanny and ArthurTriis1 and removed request for a team February 21, 2024 22:01
Copy link
Contributor

vtex-io-ci-cd bot commented Feb 21, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@wender wender merged commit 52ccaeb into master Feb 23, 2024
4 of 6 checks passed
@wender wender deleted the bugfix/removing-unused-algorithm branch February 23, 2024 17:20
Copy link
Contributor

vtex-io-ci-cd bot commented Feb 23, 2024

Your PR has been merged! App is being published. 🚀
Version 3.129.5 → 3.129.6

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant