Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yank 3.127.1 changes #659

Merged
merged 1 commit into from
Mar 6, 2024
Merged

Yank 3.127.1 changes #659

merged 1 commit into from
Mar 6, 2024

Conversation

thalytafabrine
Copy link
Member

What problem is this solving?

Revert changes made here: https://github.com/vtex-apps/search-result/pull/645/files

How to test it?

Workspace

Screenshots or example usage:

Before:

scroll.mp4

After:

fixed-scroll.mp4

How does this PR make you feel? 🔗

![](put .gif link here - can be found under "advanced" on giphy)

@thalytafabrine thalytafabrine requested review from a team as code owners March 4, 2024 15:57
@thalytafabrine thalytafabrine requested review from icazevedo, eduardoformiga and lucasfp13 and removed request for a team March 4, 2024 15:57
Copy link
Contributor

vtex-io-ci-cd bot commented Mar 4, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

Copy link

github-actions bot commented Mar 4, 2024

Fails
🚫

Please remove the line ## [3.127.1] - 2023-10-24 [YANKED] from CHANGELOG.md
This will be automatically added once this PR is merged.

Generated by 🚫 dangerJS against c59d5b4

@thalytafabrine thalytafabrine merged commit 14ff8a5 into master Mar 6, 2024
2 of 6 checks passed
@thalytafabrine thalytafabrine deleted the fix/scroll branch March 6, 2024 09:13
Copy link
Contributor

vtex-io-ci-cd bot commented Mar 6, 2024

Your PR has been merged! App is being published. 🚀
Version 3.129.7 → 3.129.8

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants