Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add with session metric #147

Merged
merged 3 commits into from
Aug 19, 2024

Conversation

enzomerca
Copy link
Contributor

What problem is this solving?

We currently have a lot of logs for "User not authenticated, make sure the query is private", which comes from the sessionData being null.
This PR adds a metric that allow us to understand where requests without sessionData are coming from.
We expect to reduce the number of logs and improve B2B Suite observability.

@enzomerca enzomerca requested a review from a team July 11, 2024 20:11
Copy link

vtex-io-ci-cd bot commented Jul 11, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Jul 11, 2024

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

Copy link

github-actions bot commented Jul 11, 2024

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 79, PR deletions = 1

Generated by 🚫 dangerJS against bb99c39

Copy link

sonarcloud bot commented Aug 19, 2024

@enzomerca enzomerca merged commit 20f824d into master Aug 19, 2024
12 checks passed
@enzomerca enzomerca deleted the fix/B2BTEAM-1689-add-with-session-metric branch August 19, 2024 16:25
Copy link

vtex-io-ci-cd bot commented Aug 19, 2024

Your PR has been merged! App is being published. 🚀
Version 1.44.0 → 1.44.1

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants