Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: storefront permissions considers inactive organizations [KI 927174] #149

Merged
merged 7 commits into from
Aug 8, 2024

Conversation

icaroov
Copy link
Contributor

@icaroov icaroov commented Jul 17, 2024

What problem is this solving?
When a user has more than one organization assigned and the first registered one is inactive, the system does not recognize that the user has other active organizations after login.

How should this be manually tested?

  • Create two organizations and assign the same user/email to both;
  • Inactivate the first organization created;
  • Log in to the website.

Copy link

vtex-io-ci-cd bot commented Jul 17, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

vtex-io-docs-bot bot commented Jul 17, 2024

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

Copy link

github-actions bot commented Jul 17, 2024

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 11, PR deletions = 8

Generated by 🚫 dangerJS against c03ce25

Copy link
Contributor

@enzomerca enzomerca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, going to merge/deploy next week.

Copy link

sonarcloud bot commented Aug 8, 2024

@enzomerca enzomerca merged commit 4bf1759 into vtex-apps:master Aug 8, 2024
20 of 21 checks passed
Copy link

vtex-io-ci-cd bot commented Aug 8, 2024

Your PR has been merged! App is being published. 🚀
Version 1.43.4 → 1.43.5

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants