Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/force setProfile to use valid costCenter - [KI 945609] #162

Merged
merged 12 commits into from
Oct 15, 2024

Conversation

giurigaud
Copy link
Contributor

@giurigaud giurigaud commented Sep 24, 2024

What problem is this solving?

Buyers cannot log in if they are associated with a deleted cost center

How should this be manually tested?

1- create Org
2- create CC1
3- create CC2
4- associate user 1 with CC1
5- associate user 1 with CC2
6- delete CC1
7- try to log in with user 1

Screenshots or example usage:

Before change
https://github.com/user-attachments/assets/c874c3a0-e458-4881-81d3-e6b52bda7a5e

After change

Uploading deleteCostCenter-afterChange.mov…

Screenshot 2024-10-02 at 11 48 42

Uploading deleteCostCenter-afterChange.mov…

Copy link

vtex-io-ci-cd bot commented Sep 24, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@giurigaud giurigaud changed the title fix: force setProfile to use valid costCenter fix/force setProfile to use valid costCenter - [KI 945609] Sep 24, 2024
Copy link

github-actions bot commented Sep 30, 2024

Messages
📖 ❤️ Thanks!
📖

🎉 PR additions = 44, PR deletions = 6

Generated by 🚫 dangerJS against 53eacc5

Copy link
Contributor

@enzomerca enzomerca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the fix still not working in the "after" video. Did you upload the correct video?

node/service.json Show resolved Hide resolved
@giurigaud
Copy link
Contributor Author

It looks like the fix still not working in the "after" video. Did you upload the correct video?

Uploading deleteCostCenter-afterChange.mov…

I'm sorry, this is the right video

Copy link

sonarcloud bot commented Oct 15, 2024

@enzomerca enzomerca merged commit a0a068c into vtex-apps:master Oct 15, 2024
19 of 20 checks passed
Copy link

vtex-io-ci-cd bot commented Oct 15, 2024

Your PR has been merged! App is being published. 🚀
Version 1.44.12 → 1.44.13

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants