-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/force setProfile to use valid costCenter - [KI 945609] #162
Conversation
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the fix still not working in the "after" video. Did you upload the correct video?
Uploading deleteCostCenter-afterChange.mov… I'm sorry, this is the right video |
Quality Gate passedIssues Measures |
Your PR has been merged! App is being published. 🚀 After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:
After that your app will be updated on all accounts. For more information on the deployment process check the docs. 📖 |
What problem is this solving?
Buyers cannot log in if they are associated with a deleted cost center
How should this be manually tested?
1- create Org
2- create CC1
3- create CC2
4- associate user 1 with CC1
5- associate user 1 with CC2
6- delete CC1
7- try to log in with user 1
Screenshots or example usage:
Before change
https://github.com/user-attachments/assets/c874c3a0-e458-4881-81d3-e6b52bda7a5e
After change
Uploading deleteCostCenter-afterChange.mov…
Uploading deleteCostCenter-afterChange.mov…