Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended Master Data Class and Builder delete #151

Merged
merged 10 commits into from
Oct 31, 2023

Conversation

GabrielBarross
Copy link
Contributor

@GabrielBarross GabrielBarross commented Oct 18, 2023

What is the purpose of this pull request?

Since there is no intention to change the affiliates schemas from now on, we are setting s fixed schema for the Master Data client to work with, not using the Master Data Builder anymore, since there is a lot of indexation problems related to it

Since the last schema version created by the Builder based on our most recent structure is the 1.7.0, everyone that updates the app for this or newer versions will use the last schema generated.

What problem is this solving?

  • Builder Hub Flow

How to test it?

  • Access the benesonb2b on gabrielbarrosaffonso workspace

Screenshots or example usage

I created an example app to test if this new function that returns the MD Client works.
Based on the tests, even when a new version exists, it stills use the fixed schema defined to create a new document :)

image image image image

How does this PR make you feel? 🔗

Types of changes

  • Chore (non-breaking change which doesn't change any functionalities)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@GabrielBarross GabrielBarross self-assigned this Oct 18, 2023
@GabrielBarross GabrielBarross requested a review from a team as a code owner October 18, 2023 17:36
@GabrielBarross GabrielBarross requested review from ConradoClark and removed request for a team October 18, 2023 17:36
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Oct 18, 2023

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

Copy link

@ConradoClark ConradoClark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ConradoClark
Copy link

LGTM

Só dá uma olhada @GabrielBarross , que parece que na build deu uns erros de typing

@GabrielBarross GabrielBarross merged commit acb87f7 into main Oct 31, 2023
@GabrielBarross GabrielBarross deleted the fix-extended-md-class branch October 31, 2023 13:03
@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Oct 31, 2023

Your PR has been merged! App is being published. 🚀
Version 1.7.1 → 1.8.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants