Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise up timeouts configurations #77

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

## [Unreleased]

### Added

- Change default timeout for clients to `5000 ms`
- Raise service timeout configuration to `10 s`
- Reduce retries to 2

## [0.48.0] - 2022-06-15

### Added
Expand Down
6 changes: 2 additions & 4 deletions manifest.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "affiliates",
"vendor": "vtex",
"version": "0.48.0",
"version": "0.49.0-beta.0",
"title": "Affiliates",
"description": "App that adds support for affiliates on IO stores",
"mustUpdateAt": "2018-01-04",
Expand Down Expand Up @@ -32,9 +32,7 @@
"messages": "1.x",
"admin": "0.x"
},
"scripts": {
"prereleasy": "bash lint.sh"
},
"scripts": {},
"credentialType": "absolute",
"policies": [
{
Expand Down
4 changes: 2 additions & 2 deletions node/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ import { getAffiliate } from './resolvers/getAffiliate'
import { fieldResolvers } from './resolvers/fieldResolvers'
import { getAffiliateByEmail } from './resolvers/getAffiliateByEmail'

const TIMEOUT_MS = 1000
const TIMEOUT_MS = 5000

// This is the configuration for clients available in `ctx.clients`.
const clients: ClientsConfig<Clients> = {
Expand All @@ -43,7 +43,7 @@ const clients: ClientsConfig<Clients> = {
options: {
// All IO Clients will be initialized with these options, unless otherwise specified.
default: {
retries: 3,
retries: 2,
timeout: TIMEOUT_MS,
},
},
Expand Down
2 changes: 1 addition & 1 deletion node/service.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"memory": 256,
"ttl": 10,
"timeout": 2,
"timeout": 10,
"minReplicas": 2,
"maxReplicas": 4,
"workers": 1,
Expand Down