feat: rating summary #2682
Open
feat: rating summary #2682
+461
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Guilera
force-pushed
the
feat/rating-summary
branch
from
c94885e to
5507fd7
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Guilera
requested review from
lariciamota,
pedromtec,
eduardoformiga and
lucasfp13
Guilera
force-pushed
the
feat/rating-summary
branch
from
5507fd7 to
8b569e0
Compare
Guilera
force-pushed
the
feat/reviews-and-ratings
branch
from
d57303d to
2203c7f
Compare
packages/components/src/molecules/ProgressStatus/ProgressStatus.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/organisms/RatingSummary/RatingSummary.tsx
Outdated
Show resolved
Hide resolved
Guilera
force-pushed
the
feat/reviews-and-ratings
branch
2 times, most recently
from
cc15cdd to
33db057
Compare
Guilera
force-pushed
the
feat/rating-summary
branch
from
8b569e0 to
a846caf
Compare
pedromtec
reviewed
Feb 20, 2025
Comment on lines
+16
to
+18
| /** | ||
| * Optional test ID for testing. | ||
| */ |
There was a problem hiding this comment.
just to keep the pattern
Suggested change
| /** | |
| * Optional test ID for testing. | |
| */ | |
| /** | |
| * ID to find this component in testing tools (e.g.: cypress, testing library, and jest). | |
| */ |
pedromtec
reviewed
Feb 20, 2025
| export const RatingDistribution = forwardRef< | ||
| HTMLOListElement, | ||
| RatingDistributionProps | ||
| >(function ProgressStatus( |
There was a problem hiding this comment.
Should it be RatingDistribution ?
Suggested change
| >(function ProgressStatus( | |
| >(function RatingDistribution( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
To add the Rating Summary component
How it works?
The component is responsible for:
Important
If the product has no reviews, the component should display a message saying that there are no reviews yet.
Both the text from the button and the text from number of reviews changes when there isn't any review yet.
Important
Plural and singular cases for the text label of the rating counter must be handled
Important
The component shouldn't be displayed if the product has no reviews and the user is not on desktop
Starters Deploy Preview
PREVIEW
References
FEATURE BRANCH
JIRA SFS-2166
JIRA SFS-2167
JIRA SFS-2069