Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add yarn to volta config #2698

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: add yarn to volta config #2698

wants to merge 1 commit into from
+2 −1

Conversation

pedromtec
Copy link
Contributor

@pedromtec pedromtec commented Feb 21, 2025 •
edited by hellofanny
Loading

What's the purpose of this pull request?

  • Adds yarn version to volta config.

After the changes in core we added the ppm version but we haven't set any version to yarn.

image

TODO: check faststore cli

How to test it?

  • Update the package.json of the starter.store with this codesanbox version
  • Attempts to run yarn build
  • You should be able to build the project without the previous error

@codesandbox-ci CodeSandbox CI
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@hellofanny hellofanny marked this pull request as ready for review February 21, 2025 17:19
@hellofanny hellofanny requested a review from a team as a code owner February 21, 2025 17:19
@hellofanny hellofanny requested review from emersonlaurentino and renatomaurovtex and removed request for a team February 21, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hellofanny hellofanny hellofanny approved these changes

@emersonlaurentino emersonlaurentino Awaiting requested review from emersonlaurentino emersonlaurentino is a code owner automatically assigned from vtex/faststore

@renatomaurovtex renatomaurovtex Awaiting requested review from renatomaurovtex renatomaurovtex is a code owner automatically assigned from vtex/faststore

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pedromtec @hellofanny