Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing request config to VBase's getJSON method #552

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mairatma
Copy link
Contributor

@mairatma mairatma commented Nov 8, 2023

What is the purpose of this pull request?

Allow passing request options when calling VBase's getJSON method.

What problem is this solving?

Today it isn't possible to send custom per-request options for VBase's getJSON method, so we can't use the forceMaxAge option per request, for example. This extra param will also allow passing a new request config that will added in a subsequent PR.

How should this be manually tested?

  • Build the codebase and verify that there were no errors.
  • Link this npm package into an app, within a linked workspace, and make sure that vbase calls are working as before.

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@mairatma mairatma marked this pull request as ready for review November 8, 2023 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant