Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EDU-10966] Solving validation errors in the orders API #1061

Merged
merged 6 commits into from
Dec 1, 2023

Conversation

PedroAntunesCosta
Copy link
Contributor

Errors indicated by the OpenAPI validator sheet

from `allOf` and from components' schemas
@PedroAntunesCosta PedroAntunesCosta requested a review from a team December 1, 2023 00:54
@PedroAntunesCosta PedroAntunesCosta self-assigned this Dec 1, 2023
Copy link

github-actions bot commented Dec 1, 2023

Thanks for your contribution. The .json file will be checked now with Spectral.

},
"price": {
"type": "integer",
"format": "int32",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acho que não estamos utilizando mais o parâmetro "format": "int32".

@@ -17839,293 +17231,124 @@
"format": "int32",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acho que não estamos utilizando mais o parâmetro "format": "int32".

},
"manualDiscountValue": {
"type": "integer",
"format": "int32",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acho que não estamos utilizando mais o parâmetro "format": "int32".

},
"manualIncrementValue": {
"type": "integer",
"format": "int32",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acho que não estamos utilizando mais o parâmetro "format": "int32".

},
"totalChangeValue": {
"type": "integer",
"format": "int32",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acho que não estamos utilizando mais o parâmetro "format": "int32".

Copy link
Contributor

@ricardoaerobr ricardoaerobr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apenas remover os locais onde estão presentes o parâmetro "format": "int32".

@ricardoaerobr ricardoaerobr self-requested a review December 1, 2023 17:35
Copy link
Contributor

@ricardoaerobr ricardoaerobr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@PedroAntunesCosta PedroAntunesCosta merged commit e703d9f into master Dec 1, 2023
1 of 2 checks passed
@PedroAntunesCosta PedroAntunesCosta deleted the orders-validator-issues branch December 1, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants