Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

23H2KR5 | Promotions & Taxes API #1066

Merged
merged 11 commits into from
Dec 19, 2023

Conversation

geisecosta
Copy link
Contributor

Types of changes

  • New content (endpoints, descriptions or fields from scratch)
  • Improvement (make an endpoint's title or description even better)
  • Spelling and grammar accuracy (self-explanatory)

Changelog

Do not forget to update your changes to our Developer Portal's changelog. Did you create a release note?

  • Yes, I already created a release note about this change.
  • No, but I am going to.

@geisecosta geisecosta requested a review from a team December 5, 2023 20:11
Copy link

github-actions bot commented Dec 5, 2023

Thanks for your contribution. The .json file will be checked now with Spectral.

VTEX - Promotions & Taxes API.json Outdated Show resolved Hide resolved
VTEX - Promotions & Taxes API.json Outdated Show resolved Hide resolved
@@ -9207,7 +9207,7 @@
"Notifications"
],
"summary": "Usage notification",
"description": "Usage notification",
"description": "Usage notification.\r\n\r\n## Permissions\r\n\r\nAny user or [application key](https:\/\/developers.vtex.com\/docs\/guides\/api-authentication-using-application-keys) must have at least one of the appropriate [License Manager resources](https:\/\/help.vtex.com\/en\/tutorial\/license-manager-resources--3q6ztrC8YynQf6rdc6euk3) to be able to successfully run this request. Otherwise they will receive a status code `403` error. These are the applicable resources for this endpoint:\r\n\r\n| **Product** | **Category** | **Resource** |\r\n| --------------- | ----------------- | ----------------- |\r\n| Rates and Benefits | Manage benefits and rates | **GerenciarPromocoesETarifas** |\r\n\r\nThere are no applicable [predefined roles](https:\/\/help.vtex.com\/en\/tutorial\/predefined-roles--jGDurZKJHvHJS13LnO7Dy) for this resource list. You must [create a custom role](https:\/\/help.vtex.com\/en\/tutorial\/roles--7HKK5Uau2H6wxE1rH5oRbc#creating-a-role) and add at least one of the resources above in order to use this endpoint.To learn more about machine authentication at VTEX, see [Authentication overview](https:\/\/developers.vtex.com\/docs\/guides\/authentication).\r\n\r\n>\u2757 To prevent integrations from having excessive permissions, consider the [best practices for managing app keys](https:\/\/help.vtex.com\/en\/tutorial\/best-practices-application-keys--7b6nD1VMHa49aI5brlOvJm) when assigning License Manager roles to integrations.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

O que é usage notification? Acho que dá para melhorar essa descrição

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@julia-rabello , já entrei em contato com o time para obter mais informações sobre esse endpoint, assim que eles retornarem irei abrir um novo PR para incluir a descrição.

VTEX - Promotions & Taxes API.json Outdated Show resolved Hide resolved
VTEX - Promotions & Taxes API.json Outdated Show resolved Hide resolved
VTEX - Promotions & Taxes API.json Outdated Show resolved Hide resolved
VTEX - Promotions & Taxes API.json Outdated Show resolved Hide resolved
VTEX - Promotions & Taxes API.json Outdated Show resolved Hide resolved
VTEX - Promotions & Taxes API.json Outdated Show resolved Hide resolved
VTEX - Promotions & Taxes API.json Outdated Show resolved Hide resolved
@julia-rabello
Copy link
Contributor

Falta adicionar permissões para os demais endpoints.

@geisecosta geisecosta merged commit 4a0605e into master Dec 19, 2023
0 of 3 checks passed
@geisecosta geisecosta deleted the EDU-10351-23H2KR5-Promotions-&-Taxes-API branch December 19, 2023 17:08
karenkrieger pushed a commit that referenced this pull request Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants