Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete unused components orders API PII version and schema corrections #1326

Merged

Conversation

Isabella-Veloso
Copy link
Contributor

@Isabella-Veloso Isabella-Veloso commented Sep 25, 2024

  • Deleting duplicated components schemas without mention.
  • Get order: Correcting "country" schema from object to string.
  • List order: Correcting list as an array of objects.

EDIT: made other improvements after.

Types of changes

  • New content (endpoints, descriptions or fields from scratch)
  • Improvement (make an endpoint's title or description even better)
  • Spelling and grammar accuracy (self-explanatory)

Changelog

Do not forget to update your changes to our Developer Portal's changelog. Did you create a release note?

  • Yes, I already created a release note about this change.
  • No, but I am going to.

Copy link

Thanks for your contribution. The .json file will be checked now with Spectral.

Copy link
Contributor

@julia-rabello julia-rabello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the callouts in the description as suggested. Everything else LGTM.

VTEX - Orders API (PII version).json Outdated Show resolved Hide resolved
@Isabella-Veloso Isabella-Veloso merged commit 770588e into master Sep 26, 2024
2 of 3 checks passed
@Isabella-Veloso Isabella-Veloso deleted the Delete-unused-componsents-Orders-API-PII-version- branch September 26, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants