Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/tksio 549 #103

Open
wants to merge 2 commits into
base: 3.x
Choose a base branch
from

Conversation

jailsondamasceno
Copy link

What is the purpose of this pull request?

Solve the problem of the document field (CPF) blocking even with the empty document.

What problem is this solving?

This pull request is for fixing a bug: When deleting the user's document, (CPF) it no longer returns null, but an empty string, with currently validating only null, so the system is blocking the document field even with the empty field. As a result, the user is unable to register the document for the first time.

How should this be manually tested?

  1. Pass the blockDocument property in the declaration of the my-account application in the store

  2. Link the vtex.my-account application to the tksio-549 branch in the my-account module. It is a dependency.

  3. Link the three store / my-account / profile-form repositories and change the property value in the store. By default, the speaker is insufficient.
    If you do not pass the property or pass the false value, the field allows changes.
    If it is set to true and the field still has no saved value, the field will also allow editing, if the field is already saved, the field is blocked.

WS to test

https://profileform--tokstokio.myvtex.com/account/#/profile/edit

Screenshots or example usage

prop

image

Before

image

After

image

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Mar 18, 2021

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@jailsondamasceno jailsondamasceno changed the base branch from master to 3.x March 18, 2021 14:55
@jailsondamasceno
Copy link
Author

jailsondamasceno commented Mar 18, 2021

@salesfelipe Good Morning . There was some change that now the user's document does not return null anymore, but empty. As our verification is only null, the system is blocking the document field, so if the user signs up using social media accounts he cannot add the document field. This change corrects this problem.
I will do the same thing for the master with you had asked in the previous task. I will be available for any questions

Resolved in Master too: #104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant