Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(filter): add Filter with Combobox page #1975

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kevinch
Copy link
Contributor

@kevinch kevinch commented Sep 26, 2024

There was no link to the Storybook example of a Filter with Combobox component

Summary

Add sub page of the Filter documentation.

Examples

Screenshot 2024-09-26 at 13 24 46

There was no link to the Storybook example of a Filter with Combobox component
@kevinch kevinch requested a review from a team as a code owner September 26, 2024 16:21
Copy link

vercel bot commented Sep 26, 2024

Deployment failed with the following error:

You don't have permission to create a Preview Deployment for this project.

View Documentation: https://vercel.com/docs/accounts/team-members-and-roles

@kevinch
Copy link
Contributor Author

kevinch commented Sep 26, 2024

Team, i ran the docs locally and was able to build:docs without error. But I'm not sure if we need to update the packages/docs/pages/components/filter/_meta.json file.

@davicostalf
Copy link
Contributor

@kevinch Following the current documentation structure, this should be an example in the Filter overview page. Like the examples in the Drawer documentation.

@kevinch
Copy link
Contributor Author

kevinch commented Sep 26, 2024

Got it, I'll see to update the PR 👍

@kevinch
Copy link
Contributor Author

kevinch commented Oct 4, 2024

I keep on getting strange errors while compiling the docs. I'll need help in the next Shoreline's Office Hours.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants