chore(eslint-plugin): runs auto fix

vtex · Apr 29, 2024 · b7933a4 · b7933a4
1 parent 48a21d9
commit b7933a4
Show file tree

Hide file tree

Showing 6 changed files with 73 additions and 133 deletions.
diff --git a/packages/eslint-plugin-vtex/package.json b/packages/eslint-plugin-vtex/package.json
@@ -59,7 +59,6 @@
     "@typescript-eslint/experimental-utils": "^5.15.0",
     "@typescript-eslint/parser": "^5.15.0",
     "babel-jest": "^29.7.0",
-    "eslint-plugin-jest": "^28.3.0",
     "jest": "^27.5.1",
     "tsup": "^8.0.2"
   },

diff --git a/packages/eslint-plugin-vtex/src/rules/__tests__/prefer-early-return.test.ts b/packages/eslint-plugin-vtex/src/rules/__tests__/prefer-early-return.test.ts
@@ -1,5 +1,6 @@
 import { RuleTester } from '@typescript-eslint/utils/dist/ts-eslint'
 import { AST_NODE_TYPES } from '@typescript-eslint/types'
+
 import { preferEarlyReturn } from '../prefer-early-return'
 
 const ruleTester = new RuleTester()

diff --git a/packages/eslint-plugin-vtex/src/rules/__tests__/prefer-use-effect-named-callback.test.ts b/packages/eslint-plugin-vtex/src/rules/__tests__/prefer-use-effect-named-callback.test.ts
@@ -1,5 +1,6 @@
 import { RuleTester } from '@typescript-eslint/utils/dist/ts-eslint'
 import { AST_NODE_TYPES } from '@typescript-eslint/types'
+
 import { preferUseEffectNamedCallback } from '../prefer-use-effect-named-callback'
 
 const ruleTester = new RuleTester()
@@ -14,98 +15,102 @@ const functionExpressionError = {
   type: AST_NODE_TYPES.FunctionExpression,
 } as const
 
-ruleTester.run('prefer-use-effect-named-callback', preferUseEffectNamedCallback, {
-  valid: [
-    {
-      code: `function Component() {
+ruleTester.run(
+  'prefer-use-effect-named-callback',
+  preferUseEffectNamedCallback,
+  {
+    valid: [
+      {
+        code: `function Component() {
         useEffect(function namedEffect() {}, [])
         return null
       }`,
-    },
-    {
-      code: `
+      },
+      {
+        code: `
         function Component() {
           React.useEffect(function namedEffect() {}, [])
           return null
         }
       `,
-    },
-    {
-      code: `
+      },
+      {
+        code: `
       /* eslint-env es6 */
       const effect = () => {}
       function Component() {
         useEffect(effect, [])
         return null;
       }`,
-    },
-    {
-      code: `
+      },
+      {
+        code: `
       /* eslint-env es6 */
       const effect = () => {}
       function Component() {
         React.useEffect(effect, [])
         return null;
       }`,
-    },
-    {
-      code: `
+      },
+      {
+        code: `
       /* eslint-env es6 */
       const effect = function () {}
       function Component() {
         React.useEffect(effect, [])
         return null;
       }`,
-    },
-    {
-      code: `
+      },
+      {
+        code: `
       /* eslint-env es6 */
       const effect = function () {}
       function Component() {
         React.useEffect(debouce(() => {}, 10), [])
         return null;
       }`,
-    },
-  ],
+      },
+    ],
 
-  invalid: [
-    {
-      code: `
+    invalid: [
+      {
+        code: `
         function Component() {
           useEffect(function () {}, [])
           return null
         }
       `,
-      errors: [functionExpressionError],
-    },
-    {
-      code: `
+        errors: [functionExpressionError],
+      },
+      {
+        code: `
         function Component() {
           React.useEffect(function () {}, [])
           return null
         }
       `,
-      errors: [functionExpressionError],
-    },
-    {
-      code: `
+        errors: [functionExpressionError],
+      },
+      {
+        code: `
         /* eslint-env es6 */
         function Component() {
           useEffect(() => {}, [])
           return null
         }
       `,
-      errors: [arrowFunctionError],
-    },
-    {
-      code: `
+        errors: [arrowFunctionError],
+      },
+      {
+        code: `
         /* eslint-env es6 */
         function Component() {
           React.useEffect(() => {}, [])
           return null
         }
       `,
-      errors: [arrowFunctionError],
-    },
-  ],
-})
+        errors: [arrowFunctionError],
+      },
+    ],
+  }
+)
diff --git a/packages/eslint-plugin-vtex/src/rules/prefer-early-return.ts b/packages/eslint-plugin-vtex/src/rules/prefer-early-return.ts
@@ -1,8 +1,10 @@
 import type { TSESTree } from '@typescript-eslint/utils'
 
-import { createRule } from "../createRule"
+import { createRule } from '../createRule'
 
-function isLonelyIfStatement(node: TSESTree.Node): node is TSESTree.IfStatement {
+function isLonelyIfStatement(
+  node: TSESTree.Node
+): node is TSESTree.IfStatement {
   return node.type === 'IfStatement' && node.alternate == null
 }
 
@@ -30,8 +32,9 @@ export const preferEarlyReturn = createRule<Options, any, any>({
       },
     ],
     messages: {
-      default: 'Prefer an early return to prevent nesting and improve code readability'
-    }
+      default:
+        'Prefer an early return to prevent nesting and improve code readability',
+    },
   },
 
   defaultOptions: [{ maxStatements: 1 }],
@@ -58,7 +61,12 @@ export const preferEarlyReturn = createRule<Options, any, any>({
       )
     }
 
-    function checkFunctionBody(fnNode: TSESTree.FunctionDeclaration | TSESTree.FunctionExpression | TSESTree.ArrowFunctionExpression) {
+    function checkFunctionBody(
+      fnNode:
+        | TSESTree.FunctionDeclaration
+        | TSESTree.FunctionExpression
+        | TSESTree.ArrowFunctionExpression
+    ) {
       const bodyNode = fnNode.body
 
       if (bodyNode.type !== 'BlockStatement' || bodyNode.body.length === 0) {
@@ -73,7 +81,7 @@ export const preferEarlyReturn = createRule<Options, any, any>({
 
       context.report({
         node: lastNode,
-        messageId: 'default'
+        messageId: 'default',
       })
     }
 

diff --git a/packages/eslint-plugin-vtex/src/rules/prefer-use-effect-named-callback.ts b/packages/eslint-plugin-vtex/src/rules/prefer-use-effect-named-callback.ts
@@ -1,5 +1,6 @@
 import type { TSESTree } from '@typescript-eslint/utils'
-import { createRule } from "../createRule"
+
+import { createRule } from '../createRule'
 
 const USE_EFFECT_NAME = 'useEffect'
 
@@ -40,18 +41,21 @@ export const preferUseEffectNamedCallback = createRule({
     type: 'layout',
     docs: {
       recommended: 'error',
-      description: 'Prefer useEffect with named function or constant callbacks.',
+      description:
+        'Prefer useEffect with named function or constant callbacks.',
     },
     messages: {
-      default: 'Prefer useEffect with named function or constant callbacks.'
+      default: 'Prefer useEffect with named function or constant callbacks.',
     },
-    schema: []
+    schema: [],
   },
 
   defaultOptions: [],
 
   create(context) {
-    function checkUseEffectCallExpression(callExpressionNode: TSESTree.CallExpression) {
+    function checkUseEffectCallExpression(
+      callExpressionNode: TSESTree.CallExpression
+    ) {
       if (!checkCallExpressionIsUseEffect(callExpressionNode)) {
         return
       }
@@ -86,5 +90,5 @@ export const preferUseEffectNamedCallback = createRule({
     return {
       CallExpression: checkUseEffectCallExpression,
     }
-  }
+  },
 })