feat: support flat config and eslint v9 #1073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kazupon
commented
Mar 27, 2024
docs/.vitepress/config.mts
Outdated
There was a problem hiding this comment.
avoid vitepress (vite) trouble
https://vitejs.dev/guide/troubleshooting.html#this-package-is-esm-only
kazupon
commented
Mar 27, 2024
| @@ -1,6 +1,6 @@ | |||
| import { defineLoader } from "vitepress"; | |||
| import recommended from "../../src/configs/recommended"; | |||
| import { rules } from "../.vitepress/rulesForSidebar"; | |||
| import { rules as baseRules } from "../../src/configs/base.js"; | |||
There was a problem hiding this comment.
vitepress support only esm, so require is not available. I’ve changed rules are imported.
kazupon
commented
Mar 27, 2024
src/configs/flat/recommended.ts
Outdated
There was a problem hiding this comment.
I've referenced eslint-plugin-vue for implementation.
vuejs/eslint-plugin-vue#2407
vuejs/eslint-plugin-vue#2436
kazupon
commented
Mar 27, 2024
| @@ -6,6 +6,7 @@ | |||
| "strict": true, | |||
| "esModuleInterop": true, | |||
| "resolveJsonModule": true, | |||
| "declaration": true, | |||
There was a problem hiding this comment.
To support DX in flat config, types are now also generated.
39 tasks
kazupon
changed the title
|
I've just supported eslint v9 and eslint v8.x compatibility |
Closed
7 tasks
|
release on |
|
Thanks! |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
background
The flat config will be supported officially in eslint v9 release, and the current config style will be removed in eslint v10.
We can already use flat config in recent versions of eslint v8.
https://eslint.org/docs/latest/use/configure/configuration-files-new
And some deprecated APIs was dropped :
https://eslint.org/blog/2023/09/preparing-custom-rules-eslint-v9/
about implementation
This PR supports the existing config style while also supporting flat config, and eslint v9 support
PS
I've just supported eslint v9 and eslint v8.x compatibility: 2024-04-11