Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set name attribute of radio-groups which are scoped to the instance #696

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

cravindra
Copy link

Decouples the name attribute from the model value and makes it unique
across multiple instances of radio fields which may now share the same
model value and still operate independently

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug fix
  • What is the new behavior (if this is a feature change)?
    Radio fields now generate a unique name which is shared within an instance and unique across different instances
  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No
  • Other information:

Decouples the name attribute from the model value and makes it unique
across multiple instances of radio fields which may now share the same
model value and still operate independently
@coveralls
Copy link

coveralls commented Dec 8, 2020

Coverage Status

Coverage remained the same at 89.979% when pulling ee5abf3 on cravindra:scoped-radio-groups into 721a4ee on vue-generators:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants