fix: async options resolve fix #266

vueform · Sep 28, 2022 · 5cb9ee4 · 5cb9ee4
1 parent 0d42746
commit 5cb9ee4
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 1 deletion.
diff --git a/src/composables/useOptions.js b/src/composables/useOptions.js
@@ -723,7 +723,7 @@ export default function useOptions (props, context, dep)
 
   watch(options, (n, o) => {
     if (typeof props.options === 'function') {
-      if (resolveOnLoad.value) {
+      if (resolveOnLoad.value && (!o || (n && n.toString() !== o.toString()))) {
         resolveOptions()
       }
     } else {

diff --git a/tests/unit/composables/useOptions.spec.js b/tests/unit/composables/useOptions.spec.js
@@ -3055,6 +3055,39 @@ describe('useOptions', () => {
       expect(asyncOptionsMock2).toHaveBeenCalledTimes(1)
     })
 
+    it('should not resolve options when async options does not change & resolveOnLoad=true', async () => {
+      let asyncOptionsMock = jest.fn()
+
+      const fn1 = async () => {
+        return await new Promise((resolve, reject) => {
+          asyncOptionsMock()
+          resolve([1,2,3])
+        })
+      }
+
+      const fn2 = async () => {
+        return await new Promise((resolve, reject) => {
+          asyncOptionsMock()
+          resolve([1,2,3])
+        })
+      }
+
+      let select = createSelect({
+        resolveOnLoad: true,
+        options: fn1,
+      })
+
+      await flushPromises()
+
+      expect(asyncOptionsMock).toHaveBeenCalledTimes(1)
+
+      select.vm.$parent.props.options = fn2
+
+      await flushPromises()
+
+      expect(asyncOptionsMock).toHaveBeenCalledTimes(1)
+    })
+
     it('should not resolve options when async options change & resolveOnLoad=false', async () => {
       let asyncOptionsMock = jest.fn()
       let asyncOptionsMock2 = jest.fn()