Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sfc-playground): remove comments in PROD mode to align with default behavior #11908

Closed
wants to merge 1 commit into from

Conversation

jh-leong
Copy link
Member

Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB 37.7 kB 34 kB
vue.global.prod.js 159 kB 57.6 kB 51.3 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 48.8 kB 18.8 kB 17.2 kB
createApp 55.3 kB 21.2 kB 19.4 kB
createSSRApp 59.3 kB 22.9 kB 20.9 kB
defineCustomElement 60 kB 22.8 kB 20.7 kB
overall 69 kB 26.3 kB 23.9 kB

Copy link

pkg-pr-new bot commented Sep 12, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@11908

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@11908

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@11908

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@11908

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@11908

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@11908

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@11908

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@11908

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@11908

vue

pnpm add https://pkg.pr.new/vue@11908

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@11908

commit: cd985c9

@edison1105 edison1105 added ready to merge The PR is ready to be merged. 🧹 p1-chore Priority 1: this doesn't change code behavior. scope: playground labels Sep 13, 2024
@skirtles-code
Copy link
Contributor

This looks very similar to #9594. For the same reasons I gave at #9594 (comment), I don't think we should make this change.

@edison1105
Copy link
Member

Closing as duplicate

@edison1105 edison1105 closed this Sep 13, 2024
@edison1105 edison1105 removed ready to merge The PR is ready to be merged. 🧹 p1-chore Priority 1: this doesn't change code behavior. labels Sep 13, 2024
@jh-leong jh-leong deleted the fix/playground_comment branch September 13, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants