Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-sfc): fix scope handling for props destructure in function parameters and catch clauses #12792

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

edison1105
Copy link
Member

close #12790

Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 100 kB 38 kB 34.3 kB
vue.global.prod.js 158 kB 57.8 kB 51.4 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 46.4 kB 18.2 kB 16.6 kB
createApp 54.3 kB 21.2 kB 19.3 kB
createSSRApp 58.5 kB 22.9 kB 20.9 kB
defineCustomElement 59.2 kB 22.8 kB 20.7 kB
overall 68.4 kB 26.3 kB 24 kB

Copy link

netlify bot commented Jan 30, 2025

Deploy Preview for vue-sfc-playground failed. Why did it fail? →

Name Link
🔨 Latest commit 3e2b34a
🔍 Latest deploy log https://app.netlify.com/sites/vue-sfc-playground/deploys/679b8efe9d5f1000080fdd25

Copy link

netlify bot commented Jan 30, 2025

Deploy Preview for vue-next-template-explorer failed. Why did it fail? →

Name Link
🔨 Latest commit 3e2b34a
🔍 Latest deploy log https://app.netlify.com/sites/vue-next-template-explorer/deploys/679b8efe523fcb0008f78bb5

Copy link

pkg-pr-new bot commented Jan 30, 2025

Open in Stackblitz

@vue/compiler-core

npm i https://pkg.pr.new/@vue/compiler-core@12792

@vue/compiler-sfc

npm i https://pkg.pr.new/@vue/compiler-sfc@12792

@vue/compiler-dom

npm i https://pkg.pr.new/@vue/compiler-dom@12792

@vue/compiler-ssr

npm i https://pkg.pr.new/@vue/compiler-ssr@12792

@vue/runtime-core

npm i https://pkg.pr.new/@vue/runtime-core@12792

@vue/runtime-dom

npm i https://pkg.pr.new/@vue/runtime-dom@12792

@vue/reactivity

npm i https://pkg.pr.new/@vue/reactivity@12792

@vue/server-renderer

npm i https://pkg.pr.new/@vue/server-renderer@12792

@vue/shared

npm i https://pkg.pr.new/@vue/shared@12792

vue

npm i https://pkg.pr.new/vue@12792

@vue/compat

npm i https://pkg.pr.new/@vue/compat@12792

commit: c08dae7

@edison1105 edison1105 changed the title fix(compiler-sfc): handling function parameters with same name as destructured props fix(compiler-sfc): fix scope handling for props destructure in function parameters and catch clauses Jan 30, 2025
@edison1105 edison1105 added ready to merge The PR is ready to be merged. scope: sfc 🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. labels Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 p3-minor-bug Priority 3: this fixes a bug, but is an edge case that only affects very specific usage. ready to merge The PR is ready to be merged. scope: sfc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@vue/compiler-sfc can't compile this code correct
1 participant