Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useCart): canAddToCart not working correctly #1417

Closed
wants to merge 3 commits into from

Conversation

bensinca
Copy link
Contributor

@bensinca bensinca commented Feb 6, 2023

Description

Importing the correct status types then comparing with the product stock status.

Related Issue

#1416

Motivation and Context

The use of canAddToCart is, therefore, wrong without the correct return.

Checklist: -->

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

mattmaribojoc and others added 3 commits December 31, 2022 21:50
…#1413)

* docs(composables): added useAddresses, useApi, useBilling, useCart, useCategory docs
* docs: added useCategorySearch composable doc
* docs: added useConfig
Check if `stock_status` is 'IN_STOCK' or 'OUT_OF_STOCK'. 

vuestorefront#1416
@bensinca bensinca requested a review from a team as a code owner February 6, 2023 14:23
@bensinca bensinca changed the title [Bug]: canAddToCart not working correctly Fix(useCart): canAddToCart not working correctly Feb 6, 2023
@sonarcloud
Copy link

sonarcloud bot commented Feb 6, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
6.9% 6.9% Duplication

@bensinca bensinca changed the title Fix(useCart): canAddToCart not working correctly Fix(usecart): canAddToCart not working correctly Feb 6, 2023
@bensinca bensinca changed the title Fix(usecart): canAddToCart not working correctly fix(useCart): canAddToCart not working correctly Feb 6, 2023
@bartoszherba
Copy link
Collaborator

@bensinca Thank you for the PR.
Please, create a new PR pointing to the new repository https://github.com/vuestorefront/storefront-nuxt2-magento2
Also, please include only changes that are relevant to the solved problem.

@bensinca
Copy link
Contributor Author

@sethidden
Copy link
Contributor

sethidden commented Jun 2, 2023

Closing because superseded by vuestorefront/storefront-nuxt2-magento2#3

@sethidden sethidden closed this Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants