Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix magento-sdk package location #1480

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

ThermScissorpunch
Copy link
Contributor

@ThermScissorpunch ThermScissorpunch commented Dec 12, 2023

The docs say @vue-storefront/sdk/magento-sdk but it needs to be @vue-storefront/magento-sdk right?

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSDoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

The docs say `@vue-storefront/sdk/magento-sdk` but it needs to be `@vue-storefront/magento-sdk` right?
@ThermScissorpunch ThermScissorpunch requested a review from a team as a code owner December 12, 2023 11:10
Copy link

changeset-bot bot commented Dec 12, 2023

⚠️ No Changeset found

Latest commit: 596f76b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@sethidden sethidden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The docs say @vue-storefront/sdk/magento-sdk but it needs to be @vue-storefront/magento-sdk right?

Yes, that is correct. Thank you for your contribution.

@sethidden sethidden merged commit 519b142 into vuestorefront:main Dec 12, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants