This repository has been archived by the owner on Jan 26, 2024. It is now read-only.
Added: Safe Area of Elements in the Bottom Elements(#499) #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Safe area padding on cookie notification, offline badge and bottom navigation
|
Currently only the bottom Elements in the Capybara need to have safe area, I have added them in Cookie notification, Bottom navigation and Offline Badge. |
|
Here is a tome coded video where we discussed this implementation |
|
Also added safe area padding for dropdowns. |
Fifciu
approved these changes
Jan 7, 2021
|
Added change logs in #573 |
|
Hey @Fifciu Please have a look at these changes, they looks good to me, we can merge them in the next release |
Fifciu
approved these changes
Apr 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #499
Short Description and Why It's Useful
Added Safe area padding on cookie notification, offline badge and bottom navigation
Screenshots of Visual Changes before/after (If There Are Any)
Video sharing visuals changes for this Improvement
IMPORTANT NOTICE - Remember to update
CHANGELOG.mdwith description of your changeContribution and Currently Important Rules Acceptance