This repository has been archived by the owner on Jan 26, 2024. It is now read-only.
Refactoring capybara theme #594
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AishwaryShrivastav
suggested changes
Apr 13, 2021
There was a problem hiding this comment.
Hi @ymaheshwari1 Please add change log and add proper issue in the PR
Implementation looks good.
Thanks for this improvement.
Fifciu
reviewed
Apr 14, 2021
| MCookieNotification: () => import('theme/components/molecules/m-cookie-notification'), | ||
| MOfflineBadge: () => import('theme/components/molecules/m-offline-badge'), | ||
| OBottomNavigation: () => import('theme/components/molecules/m-offline-badge'), | ||
| OModal: () => import('theme/components/organisms/o-modal'), |
There was a problem hiding this comment.
Why are they lazy laded when they are not conditionally loaded?
There was a problem hiding this comment.
Loading them lazily as using lazy-hydrate to render the components.
|
|
||
| export default { | ||
| components: { | ||
| OHeaderMinimal, | ||
| OFooter | ||
| OFooter: () => import('theme/components/organisms/o-footer'), |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #
Short Description and Why It's Useful
Taken reference from vuestorefront/vsf-default#57
Screenshots of Visual Changes before/after (If There Are Any)
IMPORTANT NOTICE - Remember to update
CHANGELOG.mdwith description of your changeContribution and Currently Important Rules Acceptance