Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add around interceptors #7000

Merged
merged 4 commits into from
Dec 22, 2023
Merged

feat: add around interceptors #7000

merged 4 commits into from
Dec 22, 2023

Conversation

bartoszherba
Copy link
Collaborator

@bartoszherba bartoszherba commented Dec 19, 2023

closing: https://vsf.atlassian.net/browse/IN-3884

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSDoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@bartoszherba bartoszherba requested a review from a team December 19, 2023 13:00
@bartoszherba bartoszherba force-pushed the feat/add-around-plugins branch from 30ebb14 to 81a0ff9 Compare December 19, 2023 13:03
Copy link
Collaborator

@WojtekTheWebDev WojtekTheWebDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really gj @bartoszherba, I left some suggestions to boost dx and make the example more clear but approved anyway

@bartoszherba bartoszherba merged commit ad50ec8 into main Dec 22, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants