Make FallbackLoaderTest more robust. #4264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThoWagen
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been noticing some intermittent failures of FallbackLoaderTest in my local environment. The problem appears to be a missed click in Mink similar to the issue discussed in #4222. In rare cases, one of the comments was not getting added correctly, which was causing a failure. This PR adds an assertion to confirm that the comment is added successfully, and refactors the retry mechanism from BulkTest into a trait so it can be reused here.
I wish there was a better solution to this problem, but at least creating a trait means that we can find all instances of the hack if we can improve upon this fix in future.