feedback

vuki656 · Aug 8, 2024 · 0ed9064 · 0ed9064
1 parent ebeffb8
commit 0ed9064
Show file tree

Hide file tree

Showing 8 changed files with 33 additions and 11 deletions.
diff --git a/lua/package-info/config.lua b/lua/package-info/config.lua
@@ -10,14 +10,14 @@ local M = {
         colors = {
             up_to_date = "#3C4048",
             outdated = "#d19a66",
-            in_error = "#ee4b2b",
+            invalid = "#ee4b2b",
         },
         icons = {
             enable = true,
             style = {
                 up_to_date = "|  ",
                 outdated = "|  ",
-                in_error = "|  ",
+                invalid = "|  ",
             },
         },
         autostart = true,

diff --git a/lua/package-info/parser.lua b/lua/package-info/parser.lua
@@ -52,7 +52,7 @@ M.parse_buffer = function()
 
     state.buffer.lines = buffer_lines
     state.dependencies.installed = installed_dependencies
-    state.dependencies.in_error = errored_dependencies
+    state.dependencies.invalid = errored_dependencies
 end
 
 return M
diff --git a/lua/package-info/state.lua b/lua/package-info/state.lua
@@ -25,7 +25,7 @@ M.dependencies = {
     -- ["dependency_name"] = {
     --      diagnostic: string - feedback
     -- }
-    in_error = {},
+    invalid = {},
 }
 
 M.buffer = {

diff --git a/lua/package-info/tests/suites/config/register_user_options_spec.lua b/lua/package-info/tests/suites/config/register_user_options_spec.lua
@@ -17,14 +17,14 @@ describe("Config register_user_options", function()
             colors = {
                 up_to_date = "#ffffff",
                 outdated = "#333333",
-                in_error = "#aaaaaa",
+                invalid = "#ff0000",
             },
             icons = {
                 enable = false,
                 style = {
                     up_to_date = "GG",
                     outdated = "NN",
-                    in_error = "TT",
+                    invalid = "",
                 },
             },
             autostart = false,

diff --git a/lua/package-info/tests/suites/virtual-text/display_on_line_spec.lua b/lua/package-info/tests/suites/virtual-text/display_on_line_spec.lua
@@ -127,4 +127,26 @@ describe("Virtual_text display_on_line", function()
         assert.are.equals(dependency.version.current, dependency_metadata.version)
         assert.are.equals(constants.HIGHLIGHT_GROUPS.up_to_date, dependency_metadata.group)
     end)
+
+    it("should display error diagnostics", function()
+        local package_json = file.create_package_json({ go = true })
+        local dependency = package_json.dependencies.next
+
+        config.setup()
+        core.load_plugin()
+
+        state.dependencies.invalid = {
+            [dependency.name] = {
+                diagnostic = "BAD"
+            },
+        }
+
+        local dependency_metadata = virtual_text.__display_on_line(dependency.position + 1, dependency.name)
+
+        file.delete(package_json.path)
+
+        assert.are.equals(config.options.icons.style.invalid, dependency_metadata.icon)
+        assert.are.equals("BAD", dependency_metadata.version)
+        assert.are.equals(constants.HIGHLIGHT_GROUPS.invalid, dependency_metadata.group)
+    end)
 end)
diff --git a/lua/package-info/tests/utils/reset.lua b/lua/package-info/tests/utils/reset.lua
@@ -17,7 +17,7 @@ M.state = function()
     state.is_virtual_text_displayed = false
     state.dependencies.outdated = {}
     state.dependencies.installed = {}
-    state.dependencies.in_error = {}
+    state.dependencies.invalid = {}
     state.buffer.id = nil
     state.buffer.lines = {}
     state.last_run.time = nil

diff --git a/lua/package-info/utils/constants.lua b/lua/package-info/utils/constants.lua
@@ -3,7 +3,7 @@ local M = {}
 M.HIGHLIGHT_GROUPS = {
     outdated = "PackageInfoOutdatedVersion",
     up_to_date = "PackageInfoUpToDateVersion",
-    in_error = "PackageInfoInErrorVersion",
+    invalid = "PackageInfoInErrorVersion",
 }
 
 M.PACKAGE_MANAGERS = {

diff --git a/lua/package-info/virtual_text.lua b/lua/package-info/virtual_text.lua
@@ -32,11 +32,11 @@ M.__display_on_line = function(line_number, dependency_name)
         }
     end
 
-    local error_dependency = state.dependencies.in_error[dependency_name]
+    local error_dependency = state.dependencies.invalid[dependency_name]
     if error_dependency then
         virtual_text = {
-            group = constants.HIGHLIGHT_GROUPS.in_error,
-            icon = config.options.icons.style.in_error,
+            group = constants.HIGHLIGHT_GROUPS.invalid,
+            icon = config.options.icons.style.invalid,
             version = error_dependency.diagnostic,
         }
     end