Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

accel-ppp: T6187: use correct CPU counts adjusted for SMT (backport #3218) #3220

Merged
merged 1 commit into from
Mar 31, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 31, 2024

Change Summary

Use vyos.cpu.get_core_count() to get the correct number of physical cores instead of halving the number of apparent logical cores — halving os.cpu_count() makes the system appear to have fewer CPUs than it really has if SMT is disabled.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe): optimization.

Component(s) name

Mainly accel-ppp

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

This is an automatic backport of pull request #3218 done by [Mergify](https://mergify.com).

@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, jestabro, sever-sever and c-po and removed request for a team March 31, 2024 00:38
@github-actions github-actions bot added the sagitta VyOS 1.4 LTS label Mar 31, 2024
@c-po c-po merged commit 9edf1e7 into sagitta Mar 31, 2024
4 checks passed
@mergify mergify bot deleted the mergify/bp/sagitta/pr-3218 branch March 31, 2024 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sagitta VyOS 1.4 LTS
Development

Successfully merging this pull request may close these issues.

2 participants