Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

system: T6193: invalid warning "is not a DHCP interface but uses DHCP name-server option" #3223

Merged
merged 1 commit into from
Apr 1, 2024
Merged

system: T6193: invalid warning "is not a DHCP interface but uses DHCP name-server option" #3223

merged 1 commit into from
Apr 1, 2024

Conversation

c-po
Copy link
Member

@c-po c-po commented Apr 1, 2024

Change Summary

This fixes an invalid warning when using a DHCP VLAN interface to retrieve the system nameserver to be used. VLAN CLI config is not properly expanded leading to a false warning:

[ system name-server eth1.10 ]
WARNING: "eth1.10" is not a DHCP interface but uses DHCP name-server option!

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

Proposed changes

How to test

set interfaces ethernet eth1 vif 10 address 'dhcp'
set system name-server 'eth1.10'

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@c-po
system: T6193: invalid warning "is not a DHCP interface but uses DHCP…
61e70c5 
… name-server option"

This fixes an invalid warning when using a DHCP VLAN interface to retrieve the
system nameserver to be used. VLAN CLI config is not properly expanded
leading to a false warning:

[ system name-server eth1.10 ]
WARNING: "eth1.10" is not a DHCP interface but uses DHCP name-server option!
@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, jestabro and sever-sever and removed request for a team April 1, 2024 11:20
@c-po
Copy link
Member Author

c-po commented Apr 1, 2024 •
edited
Loading

@Mergifyio backport sagitta equuleus

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 1, 2024 •
edited
Loading

backport sagitta

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 1, 2024 •
edited
Loading

backport sagitta equuleus

✅ Backports have been created

@dmbaturin dmbaturin merged commit ecdf22f into vyos:current Apr 1, 2024
8 checks passed
This was referenced Apr 1, 2024
Merged
Merged
dmbaturin added a commit that referenced this pull request Apr 1, 2024
@dmbaturin
Merge pull request #3227 from vyos/mergify/bp/sagitta/pr-3223
e2bbbce 
system: T6193: invalid warning "is not a DHCP interface but uses DHCP name-server option" (backport #3223)
dmbaturin added a commit that referenced this pull request Apr 1, 2024
@dmbaturin
Merge pull request #3228 from vyos/mergify/bp/equuleus/pr-3223
4999f60 
system: T6193: invalid warning "is not a DHCP interface but uses DHCP name-server option" (backport #3223)
@c-po c-po deleted the T6193-dhcp-client branch April 1, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmbaturin dmbaturin Awaiting requested review from dmbaturin dmbaturin is a code owner automatically assigned from vyos/reviewers

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev is a code owner automatically assigned from vyos/reviewers

@zdc zdc Awaiting requested review from zdc zdc is a code owner automatically assigned from vyos/reviewers

@jestabro jestabro Awaiting requested review from jestabro jestabro is a code owner automatically assigned from vyos/reviewers

@sever-sever sever-sever Awaiting requested review from sever-sever sever-sever is a code owner automatically assigned from vyos/reviewers

Assignees

@c-po c-po

Labels
current
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@c-po @dmbaturin