Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T6203: remove obsoleted xml lib (backport #3255) #3258

Merged
merged 2 commits into from
Apr 6, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 5, 2024

Change Summary

The vyos.xml modules and scripts were replaced with vyos.xml_ref to (1) address a bug with defaults under tag nodes and (2) support extensions (T5218). Remove missed remaining reference in op-mode script otp.py and remove obsoleted code.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

Proposed changes

How to test

git ls-files *.py | xargs pylint | grep E0611 | grep xml

Smoketest result

make test 2>&1|tee out.test
tail -n 12 out.test
DEBUG - EXITCODE:0
 INFO - Smoketest finished successfully!
 INFO - Powering off system
DEBUG - poweroff now
 INFO - Shutting down virtual machine
 INFO - Waiting for shutdown...
DEBUG - poweroff now
 INFO - Waiting for shutdown...
DEBUG - poweroff now
 INFO - VM is shut down!
 INFO - Cleaning up
 INFO - Removing disk file: testinstall-20240406-010238-53ee.img

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

This is an automatic backport of pull request #3255 done by [Mergify](https://mergify.com).

jestabro added 2 commits April 5, 2024 19:47
The vyos.xml functionality is replaced with vyos.xml_ref.

(cherry picked from commit 28a7195)
@mergify mergify bot mentioned this pull request Apr 5, 2024
12 tasks
@github-actions github-actions bot added the sagitta VyOS 1.4 LTS label Apr 5, 2024
@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, jestabro, sever-sever and c-po and removed request for a team April 5, 2024 19:48
@c-po c-po added the backport label Apr 6, 2024
@dmbaturin dmbaturin merged commit 7dc280f into sagitta Apr 6, 2024
4 of 5 checks passed
@mergify mergify bot deleted the mergify/bp/sagitta/pr-3255 branch April 6, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants