T5949: Add option to disable USB autosuspend

[HollyGurza]

Change Summary

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Code style update (formatting, renaming)
• Refactoring (no functional changes)
• Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
• Other (please describe):

Related Task(s)

• https://vyos.dev/T5949

Related PR(s)

Component(s) name

Proposed changes

https://docs.kernel.org/driver-api/usb/power-management.html

By default used the option auto is the normal state in which the kernel is allowed to autosuspend and autoresume the device.

command set system option disable-usb-autosuspend used option on to disallow autosuspend

How to test

set system option disable-usb-autosuspend
commit
cat /etc/udev/rules.d/40-usb-autosuspend.rules

ACTION=="add", SUBSYSTEM=="usb", TEST=="power/control", ATTR{power/control}="on"

del system option disable-usb-autosuspend
commit
cat /etc/udev/rules.d/40-usb-autosuspend.rules

ACTION=="add", SUBSYSTEM=="usb", TEST=="power/control", ATTR{power/control}="auto"

Smoketest result

Checklist:

• I have read the CONTRIBUTING document
• I have linked this PR to one or more Phabricator Task(s)
• I have run the components SMOKETESTS if applicable
• My commit headlines contain a valid Task id
• My change requires a change to the documentation
• I have updated the documentation accordingly

[github-actions]

👍
No issues in PR Title / Commit Title

[dmbaturin]

The PR title and the commit messages are wrong, as @Apachez- noted above: the change adds a way to disable USB autosuspend, and doesn't disable it in the system unless the user chooses to.

Please change the title and the commit message to reflect that.

[c-po]

You add the file src/etc/udev/rules.d/40-usb-autosuspend.rules in this commit with explicit content, but also a template which will override that file.

I think you try to "overcome" the issue that the file is not populated during boot-time if there is no CLI node set under set system option.

We already have a solution for this, during system startup the system_option.py helper is already called https://github.com/vyos/vyos-1x/blob/current/src/init/vyos-router#L456 and will thus populate your template.

Please drop the src/etc/udev/rules.d/40-usb-autosuspend.rules file and let everything magically work.

Change was adressed

[c-po]

@Mergifyio backport circinus sagitta

[mergify]

backport circinus sagitta

✅ Backports have been created

• #3708 T5949: Add option to disable USB autosuspend (backport #3677) has been created for branch circinus
• #3709 T5949: Add option to disable USB autosuspend (backport #3677) has been created for branch sagitta