Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nhrp: T2326: Fixed opmode command help strings #4304

Merged
merged 1 commit into from
Jan 20, 2025
Merged

nhrp: T2326: Fixed opmode command help strings #4304

merged 1 commit into from
Jan 20, 2025

Conversation

aapostoliuk
Copy link
Contributor

@aapostoliuk aapostoliuk commented Jan 15, 2025 •
edited
Loading

Change summary

Fixed opmode command help strings

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

How to test / Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 15, 2025 •
edited
Loading

👍
No issues in PR Title / Commit Title

@dmbaturin dmbaturin changed the title nhrp: T2326: Fixed opmode command helpers nhrp: T2326: Fixed opmode command help strings Jan 15, 2025
dmbaturin
dmbaturin requested changes Jan 15, 2025
View reviewed changes
Copy link
Member

@dmbaturin dmbaturin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is good but there are no helpers there — the changes are to the help strings. Could you adjust the commit message?

@aapostoliuk
nhrp: T2326: Fixed opmode command help strings
828f448 
Fixed opmode command help strings
@aapostoliuk
Copy link
Contributor Author

aapostoliuk commented Jan 20, 2025 •
edited
Loading

@dmbaturin

The PR is good but there are no helpers there — the changes are to the help strings. Could you adjust the commit message?

done

@sever-sever sever-sever merged commit 599a442 into vyos:current Jan 20, 2025
16 checks passed
@github-actions GitHub Actions
Copy link

CI integration 👍 passed!

Details

CI logs

  • CLI Smoketests (no interfaces) 👍 passed
  • CLI Smoketests (interfaces only) 👍 passed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmbaturin dmbaturin dmbaturin requested changes

@sever-sever sever-sever sever-sever approved these changes

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev is a code owner

@jestabro jestabro Awaiting requested review from jestabro jestabro is a code owner

@c-po c-po Awaiting requested review from c-po c-po is a code owner

@fett0 fett0 Awaiting requested review from fett0

@nicolas-fort nicolas-fort Awaiting requested review from nicolas-fort

@zdc zdc Awaiting requested review from zdc

Assignees

@aapostoliuk aapostoliuk

Labels
current
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aapostoliuk @dmbaturin @sever-sever