Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syslog: T6989: fix typos and add option to disable MARK #4377

Merged
merged 2 commits into from
Mar 4, 2025

Conversation

c-po
Copy link
Member

@c-po c-po commented Mar 4, 2025

Change summary

Fix CLI validator and error message for marker interval.
Add possibility to disable the mark module.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

How to test / Smoketest result

vyos@vyos:~$ /usr/libexec/vyos/tests/smoke/cli/test_system_syslog.py
test_basic (__main__.TestRSYSLOGService.test_basic) ... ok
test_console (__main__.TestRSYSLOGService.test_console) ... ok
test_remote (__main__.TestRSYSLOGService.test_remote) ... ok
test_vrf_source_address (__main__.TestRSYSLOGService.test_vrf_source_address) ... ok

----------------------------------------------------------------------
Ran 4 tests in 10.833s

OK

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@c-po c-po requested a review from a team as a code owner March 4, 2025 13:07
@c-po c-po added the bp/circinus Create automatic backport for circinus label Mar 4, 2025
Copy link

github-actions bot commented Mar 4, 2025

👍
No issues in PR Title / Commit Title

@c-po c-po merged commit 99d929d into current Mar 4, 2025
16 of 19 checks passed
@vyosbot vyosbot added the mirror-initiated This PR initiated for mirror sync workflow label Mar 4, 2025
Copy link

github-actions bot commented Mar 4, 2025

CI integration ❌ failed!

Details

CI logs

  • CLI Smoketests (no interfaces) ❌ failed
  • CLI Smoketests (interfaces only) ❌ failed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

@kumvijaya kumvijaya removed the mirror-initiated This PR initiated for mirror sync workflow label Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bp/circinus Create automatic backport for circinus current
Development

Successfully merging this pull request may close these issues.

5 participants