Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

frr: T6023: add pending upstream patches #497

Merged
merged 1 commit into from
Feb 8, 2024
Merged

frr: T6023: add pending upstream patches #497

merged 1 commit into from
Feb 8, 2024

Conversation

c-po
Copy link
Member

@c-po c-po commented Feb 8, 2024

Change Summary

Latest stable/9.0 FRR branch has an updated version of frr-reload.py which is more strict on the commands to remove from the running config. This resulted in some issues in the codebase of FRR which are addressed in the attached patches and are pending for upstream integration.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PRs

Component(s) name

FRR

Proposed changes

How to test

make test and make testc

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@c-po
frr: T6023: add pending upstream patches
798b95e 
Latest stable/9.0 FRR branch has an updated version of frr-reload.py which
is more strict on the commands to remove from the running config. This resulted
in some issues in the codebase of FRR which are addressed in the attached patches
and are pending for upstream integration.
@github-actions github-actions bot added the current VyOS rolling release label Feb 8, 2024
@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, jestabro and sever-sever and removed request for a team February 8, 2024 21:59
@c-po c-po merged commit 8332ae7 into vyos:current Feb 8, 2024
4 of 5 checks passed
@c-po
Copy link
Member Author

c-po commented Feb 8, 2024

@Mergifyio backport sagitta

@mergify Mergify
Copy link

mergify bot commented Feb 8, 2024 •
edited
Loading

backport sagitta

✅ Backports have been created

@mergify mergify bot mentioned this pull request Feb 8, 2024
Merged
c-po added a commit that referenced this pull request Feb 9, 2024
@c-po
Merge pull request #498 from vyos/mergify/bp/sagitta/pr-497
635c8da 
frr: T6023: add pending upstream patches (backport #497)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmbaturin dmbaturin Awaiting requested review from dmbaturin dmbaturin was automatically assigned from vyos/reviewers

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev was automatically assigned from vyos/reviewers

@zdc zdc Awaiting requested review from zdc zdc was automatically assigned from vyos/reviewers

@jestabro jestabro Awaiting requested review from jestabro jestabro was automatically assigned from vyos/reviewers

@sever-sever sever-sever Awaiting requested review from sever-sever sever-sever was automatically assigned from vyos/reviewers

Assignees

@c-po c-po

Labels
current VyOS rolling release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@c-po