Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

accel-ppp: Radius patch for Dns-Server-IPv6-Address attribute #926

Open
wants to merge 1 commit into
base: current
Choose a base branch
from
Open

accel-ppp: Radius patch for Dns-Server-IPv6-Address attribute #926

wants to merge 1 commit into from

Conversation

AlexIT-FT
Copy link

@AlexIT-FT AlexIT-FT commented Mar 13, 2025 •
edited
Loading

This adds the ability to pull IPv6 DNS servers from the radius response not just hard coded in the config file

Bit of background: https://www.hardill.me.uk/wordpress/2020/03/22/contributing-to-accel-ppp/

All credits to Ben Hardill

Change summary

Just to manage the attribute Dns-Server-IPv6-Address from Radius

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@AlexIT-FT
Create 0002-Radius-Dns-Server-IPv6-Address.patch
1cb49cc 
This adds the ability to pull IPv6 DNS servers from the radius response not just hard coded in the config file

Bit of background: https://www.hardill.me.uk/wordpress/2020/03/22/contributing-to-accel-ppp/
@AlexIT-FT AlexIT-FT requested a review from a team as a code owner March 13, 2025 04:27
@github-actions GitHub Actions
Copy link

❌
PR title does not match the required format

@github-actions github-actions bot added the current VyOS rolling release label Mar 13, 2025
@AlexIT-FT AlexIT-FT changed the title Create 0002-Radius-Dns-Server-IPv6-Address.patch accel-ppp: patch : 0002-Radius-Dns-Server-IPv6-Address.patch Mar 13, 2025
@AlexIT-FT AlexIT-FT changed the title accel-ppp: patch : 0002-Radius-Dns-Server-IPv6-Address.patch accel-ppp: Radius patch for Dns-Server-IPv6-Address attribute Mar 13, 2025
@sever-sever
Copy link
Member

It is a nice practice to create a feature request from https://vyos.dev/
And refer to this task in the commit message and PR title.

@AlexIT-FT
Copy link
Author

@sever-sever
sorry, I'm new to this kind of things, next time for sure
now, just waiting for acount approval in vyod.dev

sever-sever
sever-sever approved these changes Mar 27, 2025
View reviewed changes
Copy link
Member

@sever-sever sever-sever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved as it was tested by users, ref accel-ppp/accel-ppp#69

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sever-sever sever-sever sever-sever approved these changes

@dmbaturin dmbaturin Awaiting requested review from dmbaturin dmbaturin was automatically assigned from vyos/reviewers

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev was automatically assigned from vyos/reviewers

@jestabro jestabro Awaiting requested review from jestabro jestabro was automatically assigned from vyos/reviewers

@c-po c-po Awaiting requested review from c-po c-po was automatically assigned from vyos/reviewers

At least 2 approving reviews are required to merge this pull request.

Assignees

@AlexIT-FT AlexIT-FT

Labels
current VyOS rolling release
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexIT-FT @sever-sever