T7013 route maps integration tests

[omnom62]

Change Summary

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Code style update (formatting, renaming)
• Refactoring (no functional changes)
• Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
• Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

Proposed changes

How to test

Test results

• Sanity tests passed
• Unit tests passed

Tested against VyOS versions:

• 1.3.8
• 1.4-rolling-202201010100

Checklist:

• I have read the CONTRIBUTING document
• I have linked this PR to one or more Phabricator Task(s)
• I have run the ansible sanity and unit tests
• My commit headlines contain a valid Task id
• My change requires a change to the documentation
• I have updated the documentation accordingly
• I have added unit tests to cover my changes
• I have added a file to changelogs/fragments to describe the changes

[andamasov]

GTG

[gaige]

@omnom62 I just checked out this PR and ran the integration tests against 1.3.8, 1.4.1, and 1.5-rolling; I failed all three in the asserts after

TASK [vyos_route_maps : Provide the running configuration for parsing (config to be parsed)] ***

Can you confirm which versions your tests succeeded against?

Also possible there may be a missing check-in or file, as the problem appears to be an undefined merged_commands, which may be because parsed test doesn't include the version code, and there's no default, which is likely due to parsed.yaml not calling _get_version.yaml or _populate.yaml

Errors:

    "msg": "The conditional check 'result.parsed|symmetric_difference(merged.after) == []' failed. The error was: error while evaluating conditional (result.parsed|symmetric_difference(merged.after) == []): {'before': [], 'commands': '{{ merged_commands }}', 'after': [{'route_map': 'test3', 'entries': [{'sequence': 1, 'action': 'permit', 'match': {'metric': 1, 'peer': '192.0.2.32'}, 'set': {'local_preference': '4', 'metric': '5', 'metric_type': 'type-1', 'origin': 'egp', 'originator_id': '192.0.2.34', 'tag': '5', 'weight': '4'}}]}, {'route_map': 'test1', 'entries': [{'sequence': 1, 'description': 'test', 'action': 'permit', 'continue_sequence': 2}]}]}: 'merged_commands' is undefined"
}
fatal: [v14.dc.cluetrust.com]: FAILED! => {
    "msg": "The conditional check 'result.parsed|symmetric_difference(merged.after) == []' failed. The error was: error while evaluating conditional (result.parsed|symmetric_difference(merged.after) == []): {'before': [], 'commands': '{{ merged_commands }}', 'after': [{'route_map': 'test3', 'entries': [{'sequence': 1, 'action': 'permit', 'match': {'metric': 1, 'peer': '192.0.2.32'}, 'set': {'local_preference': '4', 'metric': '5', 'metric_type': 'type-1', 'origin': 'egp', 'originator_id': '192.0.2.34', 'tag': '5', 'weight': '4'}}]}, {'route_map': 'test1', 'entries': [{'sequence': 1, 'description': 'test', 'action': 'permit', 'continue_sequence': 2}]}]}: 'merged_commands' is undefined"
}
fatal: [v15.dc.cluetrust.com]: FAILED! => {
    "msg": "The conditional check 'result.parsed|symmetric_difference(merged.after) == []' failed. The error was: error while evaluating conditional (result.parsed|symmetric_difference(merged.after) == []): {'before': [], 'commands': '{{ merged_commands }}', 'after': [{'route_map': 'test3', 'entries': [{'sequence': 1, 'action': 'permit', 'match': {'metric': 1, 'peer': '192.0.2.32'}, 'set': {'local_preference': '4', 'metric': '5', 'metric_type': 'type-1', 'origin': 'egp', 'originator_id': '192.0.2.34', 'tag': '5', 'weight': '4'}}]}, {'route_map': 'test1', 'entries': [{'sequence': 1, 'description': 'test', 'action': 'permit', 'continue_sequence': 2}]}]}: 'merged_commands' is undefined"
}

[gaige]

Please address these comments prior to merge. Also see the top-level comment on the merge_commands failure.

[omnom62]

@omnom62 I just checked out this PR and ran the integration tests against 1.3.8, 1.4.1, and 1.5-rolling; I failed all three in the asserts after

TASK [vyos_route_maps : Provide the running configuration for parsing (config to be parsed)] ***

Can you confirm which versions your tests succeeded against?

Also possible there may be a missing check-in or file, as the problem appears to be an undefined merged_commands, which may be because parsed test doesn't include the version code, and there's no default, which is likely due to parsed.yaml not calling _get_version.yaml or _populate.yaml

Errors:

    "msg": "The conditional check 'result.parsed|symmetric_difference(merged.after) == []' failed. The error was: error while evaluating conditional (result.parsed|symmetric_difference(merged.after) == []): {'before': [], 'commands': '{{ merged_commands }}', 'after': [{'route_map': 'test3', 'entries': [{'sequence': 1, 'action': 'permit', 'match': {'metric': 1, 'peer': '192.0.2.32'}, 'set': {'local_preference': '4', 'metric': '5', 'metric_type': 'type-1', 'origin': 'egp', 'originator_id': '192.0.2.34', 'tag': '5', 'weight': '4'}}]}, {'route_map': 'test1', 'entries': [{'sequence': 1, 'description': 'test', 'action': 'permit', 'continue_sequence': 2}]}]}: 'merged_commands' is undefined"
}
fatal: [v14.dc.cluetrust.com]: FAILED! => {
    "msg": "The conditional check 'result.parsed|symmetric_difference(merged.after) == []' failed. The error was: error while evaluating conditional (result.parsed|symmetric_difference(merged.after) == []): {'before': [], 'commands': '{{ merged_commands }}', 'after': [{'route_map': 'test3', 'entries': [{'sequence': 1, 'action': 'permit', 'match': {'metric': 1, 'peer': '192.0.2.32'}, 'set': {'local_preference': '4', 'metric': '5', 'metric_type': 'type-1', 'origin': 'egp', 'originator_id': '192.0.2.34', 'tag': '5', 'weight': '4'}}]}, {'route_map': 'test1', 'entries': [{'sequence': 1, 'description': 'test', 'action': 'permit', 'continue_sequence': 2}]}]}: 'merged_commands' is undefined"
}
fatal: [v15.dc.cluetrust.com]: FAILED! => {
    "msg": "The conditional check 'result.parsed|symmetric_difference(merged.after) == []' failed. The error was: error while evaluating conditional (result.parsed|symmetric_difference(merged.after) == []): {'before': [], 'commands': '{{ merged_commands }}', 'after': [{'route_map': 'test3', 'entries': [{'sequence': 1, 'action': 'permit', 'match': {'metric': 1, 'peer': '192.0.2.32'}, 'set': {'local_preference': '4', 'metric': '5', 'metric_type': 'type-1', 'origin': 'egp', 'originator_id': '192.0.2.34', 'tag': '5', 'weight': '4'}}]}, {'route_map': 'test1', 'entries': [{'sequence': 1, 'description': 'test', 'action': 'permit', 'continue_sequence': 2}]}]}: 'merged_commands' is undefined"
}

Mine are successful for all the range:
PLAY RECAP *********************************************************************
target01 : ok=118 changed=17 unreachable=0 failed=0 skipped=18 rescued=0 ignored=5
target02 : ok=118 changed=17 unreachable=0 failed=0 skipped=18 rescued=0 ignored=5
target03 : ok=119 changed=17 unreachable=0 failed=0 skipped=17 rescued=0 ignored=5
target04 : ok=118 changed=17 unreachable=0 failed=0 skipped=18 rescued=0 ignored=5

I checked in everything. Perhaps this was interim
I will also incorporate your recommendations and re-run the tests

[gaige]

Looks like we could remove _get_version.yaml now as it's not in use.

[gaige]

LGTM.
Tested under 1.3.8, 1.4.1, and VyOS 1.5-rolling-202411070006