Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T7010: fix: integration tests add unit tests #386

Merged
merged 2 commits into from
Feb 7, 2025

Conversation

gaige
Copy link
Contributor

@gaige gaige commented Feb 3, 2025

Change Summary

  • fix handling of lag interfaces for 1.3+
  • fix integration tests
  • add some unit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

https://vyos.dev/T7010

Related PR(s)

Component(s) name

vyos_lag_interfaces

Proposed changes

Updated the fact and config code to handle membership through the bond interface
instead of directly in the ethernet interface. Add appropriate tests.

How to test

ansible-test network-integration -vvvv --inventory `pwd`/inventory.network vyos_lag_interfaces

Test results


$ ansible-test network-integration -vvvv --inventory `pwd`/inventory.network vyos_lag_interfaces


PLAY RECAP *********************************************************************
v13.dc.cluetrust.com       : ok=150  changed=35   unreachable=0    failed=0    skipped=1    rescued=0    ignored=6   
v14.dc.cluetrust.com       : ok=150  changed=35   unreachable=0    failed=0    skipped=1    rescued=0    ignored=6   
v15.dc.cluetrust.com       : ok=150  changed=35   unreachable=0    failed=0    skipped=1    rescued=0    ignored=6   

Command exited with status 0 after 274.23989605903625 seconds.

  • Sanity tests passed
  • Unit tests passed

Tested against VyOS versions:

  • 1.3.8
  • 1.4.1
  • 1.5-rolling-202411070006

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the ansible sanity and unit tests
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added unit tests to cover my changes
  • I have added a file to changelogs/fragments to describe the changes

@gaige gaige requested a review from a team as a code owner February 3, 2025 03:28
Copy link
Contributor

@omnom62 omnom62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good - 1.2 integration is failing on my VM, but I guess this is OK

@andamasov andamasov requested review from a team and removed request for dmbaturin and sever-sever February 7, 2025 18:34
Copy link
Member

@andamasov andamasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@gaige gaige merged commit 0d80a81 into vyos:main Feb 7, 2025
60 checks passed
@gaige gaige deleted the T7010-lag-interfaces branch February 7, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants