Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make vyper version optional #27

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

DanielSchiavini
Copy link
Contributor

What I did

It is totally valid to have a contract without a version pragma.
Therefore, a file without a pragma shouldn't raise an error, but return None instead

Copy link
Member

@fubuloubu fubuloubu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

breaking change

@charles-cooper charles-cooper merged commit 2526c3e into vyperlang:master Sep 20, 2024
9 of 10 checks passed
@charles-cooper
Copy link
Member

charles-cooper commented Sep 20, 2024

breaking change

it's arguably a bug in the API, since the function was just introduced in 0.3.0

@DanielSchiavini DanielSchiavini deleted the optional branch September 20, 2024 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants