-
-
Notifications
You must be signed in to change notification settings - Fork 802
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat[ux]: improve hint for events kwarg upgrade #4275
base: master
Are you sure you want to change the base?
feat[ux]: improve hint for events kwarg upgrade #4275
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4275 +/- ##
===========================================
- Coverage 91.30% 53.43% -37.88%
===========================================
Files 110 110
Lines 15764 15766 +2
Branches 3461 3462 +1
===========================================
- Hits 14393 8424 -5969
- Misses 935 6717 +5782
- Partials 436 625 +189 ☔ View full report in Codecov by Sentry. |
there's something interesting going on with examples like
i guess mark_tokens() marks the wrong start+end position for the ast node. |
i'd say the mark_tokens issue is out of scope -- it should be addressed in #4364 |
follow-on commit to ebe3c0c. the hint in ebe3c0c is not specific to the user's source code, and it's a bit laborious for the user to match the call-site to the event def. this commit auto-generates the new call expression for the user to use.
What I did
How I did it
How to verify it
try compiling the following file:
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture