Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[ux]: improve hint for events kwarg upgrade #4275

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

charles-cooper
Copy link
Member

follow-on commit to ebe3c0c. the hint in ebe3c0c is not specific to the user's source code, and it's a bit laborious for the user to match the call-site to the event def. this commit auto-generates the new call expression for the user to use.

What I did

How I did it

How to verify it

try compiling the following file:

from ethereum.ercs import IERC20

def foo():
    log IERC20.Transfer(msg.sender, msg.sender, 123)

Commit message

Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

follow-on commit to ebe3c0c. the hint in ebe3c0c is
not specific to the user's source code, and it's a bit laborious for the
user to match the call-site to the event def. this commit auto-generates
the new call expression for the user to use.
@charles-cooper charles-cooper added this to the v0.4.1 milestone Oct 5, 2024
Copy link

codecov bot commented Oct 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.43%. Comparing base (c02d2d8) to head (c4cc839).
Report is 4 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (c02d2d8) and HEAD (c4cc839). Click for more details.

HEAD has 110 uploads less than BASE
Flag BASE (c02d2d8) HEAD (c4cc839)
137 27
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4275       +/-   ##
===========================================
- Coverage   91.30%   53.43%   -37.88%     
===========================================
  Files         110      110               
  Lines       15764    15766        +2     
  Branches     3461     3462        +1     
===========================================
- Hits        14393     8424     -5969     
- Misses        935     6717     +5782     
- Partials      436      625      +189     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charles-cooper
Copy link
Member Author

there's something interesting going on with examples like

log Transfer(msg.sender, msg.sender, 1)  # 1 is only one character long

i guess mark_tokens() marks the wrong start+end position for the ast node.

@charles-cooper charles-cooper added the release - must release blocker label Oct 11, 2024
@charles-cooper charles-cooper marked this pull request as ready for review October 17, 2024 17:06
@charles-cooper charles-cooper marked this pull request as draft October 17, 2024 17:06
@charles-cooper
Copy link
Member Author

i'd say the mark_tokens issue is out of scope -- it should be addressed in #4364

@charles-cooper charles-cooper marked this pull request as ready for review November 21, 2024 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release - must release blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant