refactor: Clean up debug prints #53
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w1ll1am23
reviewed
Feb 8, 2025
.gitignore
Outdated
| @@ -90,3 +90,5 @@ ENV/ | |||
|
|
|||
| # IDE | |||
| .idea/ | |||
|
|
|||
| *.json | |||
There was a problem hiding this comment.
I don't think we should add this. If we add more example equipment responses in the future is going to just make it harder to get them added in the commits.
src/pyeconet/api.py
Outdated
| _LOGGER.debug(_json) | ||
| if _LOGGER.getEffectiveLevel() == logging.DEBUG: | ||
| _LOGGER.debug("Logging json to locations_debug.json") | ||
| with open('locations_debug.json', 'w') as debug_file: |
There was a problem hiding this comment.
When this library is used in Home Assistant where will this file be written? Seems like it will result in making it more difficult to get logs from users.
Update json to print in easy to read format, adjust large json debug to write to file instead of print (and gitignore json files)
|
Good feedback, I was not considering HA logging. Does the formatted |
|
Not sure I'd assume it would but maybe not? |
|
Looks good in the |
|
Updated to change error message to debug on econet errors |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update json to print in easy to read format, adjust large json debug to write to file instead of print (and gitignore json files)