forked from forem/forem
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update web3version branch to latest forem/main #9
Open
cancelei
wants to merge
1,325
commits into
w3b3d3v:web3dev-version
Choose a base branch
from
forem:main
base: web3dev-version
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+94,159
−184,382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add role targeting to billboards * Complete form * Complete form * Fix api spec * Finalize tests
* Add bb param to billboards after save * Handle edge cases
* Add proper self-serve subscription cancel flow * Make tweak to billboard display
* Track external email clicks via redirect * Gem upgrades * Add ahoy to vcl logic
* Allow cloudflare directory to be set via variable * Tweak directory format
) * Fixed Bug 21280 - Allow Complex Markdown Structure with 3+ Ticks * Allow Complex Markdown Structure with 3+ Ticks (Revised) * Allow Complex Markdown Structure with 3+ Ticks (Revised With Comments) * Allow Complex Markdown Structure with 3+ Ticks (Revised With Comments + Added 2 Tests) --------- Co-authored-by: Ben Halpern <[email protected]>
* Add optional backup cache store * Update config/environments/production.rb Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Skip this test for now --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Explicitely require multstore cache * Put multistorecache in production.rb
* Use monkeypatch to write to secondary redis * Check against redis url * Make more safe
* Render liquid variables as plain text instead or raising error * Add test
* Render liquid variables as plain text instead or raising error * Add test * Add stripe billing portal * Adjust settings spec
* Render liquid variables as plain text instead or raising error * Add test * Add stripe billing portal * Adjust settings spec * Fix liquid escaping issue
* Revert code block rendering change * Adjust liquid error rescue
* add articles to admin tab * add comments view to user admin --------- Co-authored-by: jessleenyc <[email protected]>
* add change user modal * user email updating successfully * update path and write spec --------- Co-authored-by: jessleenyc <[email protected]>
…21324) * Make dashboard sidebar render async and adjust dashboard pagination * Adjust dashboard system spec to test sidebar * Adjust dashboard system spec to test sidebar * Adjust dashboard * Remove count header needs * Remove test for analytics org rendering * Adjust tests
* Extend cache window for reactions endpoint * Adjust specs
…21632) Co-authored-by: Ben Halpern <[email protected]>
* Test for redirect instead of render * Remove runkit
* Add basics of subforems * Add i18n * Fix french i18n
…1643) * Pass parameter to feed to get different strategies * Fix block
* Add configurable feed weights * Feed events index
* Add organization_id spec and make feed config adjustments * Add organization_id spec and make feed config adjustments * Any followed tags * Fix tests and egde cases
* Add compellingness_score to API * Fix tests
…ty (#21656) * Ensure no random feed create * Feed event counting * Adjust test
* Add basic language to feed config * Remove current user * Add languages * Tie language to score weight
* Create user activity store and beginnings of labels * User activity stub * Adjust feed config test
* Add new columns to feed configs * Update db/schema.rb
* Convert labels param upstream * Adjust cloning logic * Adjust cloning behavior
* Set label weights live in feed config * Adjust test
* Add final shuffling weight * Adjust tests * Smaller pages
* Clone impressions count zero * Article pagination to 25
…#21644) * Remove deprecated Search::Listing and update tests for empty listings results * Revert changes to test files --------- Co-authored-by: Ben Halpern <[email protected]>
* Add mobile version element * Fix schema
* Tabulate billboard counts when taking down * Improve logic
* Tabulate billboard counts when taking down * Improve logic * Add default positions for analytics insights
* Accept position in insights api * Adjust send * Position * Add default position
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Related Tickets & Documents
N/A
N/A
QA Instructions, Screenshots, Recordings
Please replace this line with instructions on how to test your changes, a note
on the devices and browsers this has been tested on, as well as any relevant
images for UI changes.
UI accessibility concerns?
If your PR includes UI changes, please replace this line with details on how
accessibility is impacted and tested. For more info, check out the
Forem Accessibility Docs.
Added/updated tests?
have not been included
[Forem core team only] How will this change be communicated?
Will this PR introduce a change that impacts Forem members or creators, the
development process, or any of our internal teams? If so, please note how you
will share this change with the people who need to know about it.
Storybook (for Crayons components)
updated. I have filled out the
Changes Requested
issue template so Community Success can help update the Admin Docs
appropriately.
CHANGELOG.md
or in a forem.dev post
replace this line with details on why this change doesn't need to be
shared
[optional] Are there any post deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?