Customizable Product data and support for attributes #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature: Index attributes
Feature/attributes
add support for numeric range attributes
add stock data
… if form is submitted
Feature/customizeable dataset
add custom fields support
…o-class Chore/split attributes into class
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed!
|
|
Kudos, SonarCloud Quality Gate passed!
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @w3bdesign
I did quiet a huge refactor according to your feedback.
Main changes are splitting the attributes related code into a own class and adding more features.
I am not sure if it will pass your code guidelines as it seems they are not completely aligned with the codacy defaults.
Unfortunately I do not have any time left to improve my additions, if you want to take them into the repository I kindly request you to do the needed (for you probably small) changes to match your A grade code style.
Greets Chris