Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding workflow relationships to graph #849

Closed
wants to merge 1 commit into from
Closed

Adding workflow relationships to graph #849

wants to merge 1 commit into from

Conversation

nissimsan
Copy link
Collaborator

@nissimsan nissimsan commented Aug 3, 2023 •
edited
Loading

Separates out workflow isnt and defs graph nodes.

@nissimsan
Copy link
Collaborator Author

Noticing this is already done on the rootTerms.json. This PR is probably not necessary.

OR13
OR13 requested changes Aug 8, 2023
View reviewed changes
Copy link
Collaborator

@OR13 OR13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the workflow RDF Class

@nissimsan nissimsan closed this Aug 8, 2023
@OR13
Copy link
Collaborator

OR13 commented Aug 8, 2023

Concrete change requests:

make sure these dereference properly:

Make sure a human can read the definition when clicking them.

Remove the unused. "Worklow.yml" class.

@TallTed TallTed mentioned this pull request Aug 8, 2023
Closed
@nissimsan nissimsan deleted the workflow-type branch August 8, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OR13 OR13 OR13 requested changes

@mprorock mprorock Awaiting requested review from mprorock

@mkhraisha mkhraisha Awaiting requested review from mkhraisha mkhraisha is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nissimsan @OR13