-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/new workflow: Common Import Credentials #853
Conversation
Could the title (and subsequent) of this workflow be changed from Relatedly, please change the title of this PR to |
@TallTed the intention of the title was to describe these credentials as common constituents of an importation workflow. I was thinking the title suggests this in a succinct way, but I'd appreciate an outside view so if you feel strongly I can change it. Regardless, I've updated the description to reword things a bit - hopefully that helps some! |
docs/sections/workflows.html
Outdated
tags: | ||
- Steel | ||
- Agriculture | ||
- OilAndGas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Multimodal BOL, Commercial Invoice don't apply to O&G, maybe remove OG?
@@ -89,7 +89,7 @@ | |||
}, | |||
{ | |||
"type": "MillTestReportCredential", | |||
"count": 187 | |||
"count": 191 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nissimsan just a warning about this number going up : /
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh I know... Looking at it all day. Very sad! :(
- Steel | ||
- Agriculture | ||
- Ecommerce | ||
- Other |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the value of "Other" as a tag?
Happy to merge out of band if name change goes through as ted requested and the OG comment is addressed |
@mkhraisha I've improved the description in response to Ted's suggestion (see above), and made the requested changes. Ok to merge? |
@rhofvendahl , are you aware of https://w3c-ccg.github.io/traceability-vocab/#us-cbp-entry? |
This PR creates a new workflow
Common Import Credentials
, describing a simple interaction between an importer, broker and CBP involving some common credentials.