Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/new workflow: Common Import Credentials #853

Merged
merged 6 commits into from
Aug 22, 2023

Conversation

rhofvendahl
Copy link
Collaborator

This PR creates a new workflow Common Import Credentials, describing a simple interaction between an importer, broker and CBP involving some common credentials.

@TallTed
Copy link
Contributor

TallTed commented Aug 9, 2023

Could the title (and subsequent) of this workflow be changed from Common Import Credentials to Common Credentials for Imports? There might be another rephrasing that would be better. I'm just concerned with making it read more clearly, especially for non-English and non-Importer consumers who are just trying to learn.

Relatedly, please change the title of this PR to Feat/new workflow: Common Credentials for Imports so it's clearly different from other future/past Feat/new workflow PRs.

@rhofvendahl
Copy link
Collaborator Author

@TallTed the intention of the title was to describe these credentials as common constituents of an importation workflow. I was thinking the title suggests this in a succinct way, but I'd appreciate an outside view so if you feel strongly I can change it. Regardless, I've updated the description to reword things a bit - hopefully that helps some!

@rhofvendahl rhofvendahl changed the title Feat/new workflow Feat/new workflow: common import credentials Aug 15, 2023
@rhofvendahl rhofvendahl changed the title Feat/new workflow: common import credentials Feat/new workflow: Common Import Credentials Aug 15, 2023
tags:
- Steel
- Agriculture
- OilAndGas
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Multimodal BOL, Commercial Invoice don't apply to O&G, maybe remove OG?

@@ -89,7 +89,7 @@
},
{
"type": "MillTestReportCredential",
"count": 187
"count": 191
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nissimsan just a warning about this number going up : /

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I know... Looking at it all day. Very sad! :(

- Steel
- Agriculture
- Ecommerce
- Other
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the value of "Other" as a tag?

@mkhraisha
Copy link
Collaborator

Happy to merge out of band if name change goes through as ted requested and the OG comment is addressed

@rhofvendahl
Copy link
Collaborator Author

@mkhraisha I've improved the description in response to Ted's suggestion (see above), and made the requested changes. Ok to merge?

@nissimsan
Copy link
Collaborator

@rhofvendahl rhofvendahl merged commit f6f2bdc into w3c-ccg:main Aug 22, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants