Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflows and exchanges endpoints. #382

Merged
merged 16 commits into from
May 29, 2024
Merged

Conversation

wes-smith
Copy link
Collaborator

@wes-smith wes-smith commented Apr 23, 2024

Copy link
Collaborator

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trivial, human-facing

exchanges.yml Outdated Show resolved Hide resolved
exchanges.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@brianorwhatever brianorwhatever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The OpenAPI linting is currently failing and I have pointed out some fixes required as well as the following:

  • The no-empty-servers rule is triggered by this however I don't think we should include a server in this repo. In fact we should remove the servers from the other API files
  • The security schemes seem fine to me however they are triggering the security-defined rule. I am not sure why it is allowing them in other files (maybe it just isn't checking them as the files aren't changing) however they look the same here as they do in the other API files.

exchanges.yml Show resolved Hide resolved
exchanges.yml Outdated Show resolved Hide resolved
exchanges.yml Show resolved Hide resolved
exchanges.yml Show resolved Hide resolved
exchanges.yml Show resolved Hide resolved
@wes-smith wes-smith merged commit c02e73f into main May 29, 2024
1 check passed
@msporny msporny deleted the add-workflows-endpoints branch May 29, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants