Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add constructor to InstallEvent #1729

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Conversation

sisidovski
Copy link
Contributor

@sisidovski sisidovski commented Sep 27, 2024

This closes #1713.

Originally InstallEvent was removed in #1207, then added again in #1701, but currently it doesn't have a constructor for no reason.


Preview | Diff

Copy link
Collaborator

@mkruisselbrink mkruisselbrink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@mkruisselbrink mkruisselbrink merged commit 9dbcd10 into w3c:main Sep 27, 2024
2 checks passed
github-actions bot added a commit that referenced this pull request Sep 27, 2024
SHA: 9dbcd10
Reason: push, by mkruisselbrink

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@sisidovski sisidovski deleted the install-event branch September 27, 2024 21:04
github-actions bot added a commit to asleekgeek/ServiceWorker that referenced this pull request Oct 1, 2024
SHA: 9dbcd10
Reason: push, by pull[bot]

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shouldn't InstallEvent has a constructor?
2 participants