Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial: Update computation step "comp_embedded_control" (formerly step 2c) text for clarity #2299

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Editorial: Update computation step "comp_embedded_control" (formerly step 2c) text for clarity #2299

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6ab7258
Update index.html
MelSumner Jul 31, 2024
03a72ef
chore: prettier
MelSumner Jul 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions accname/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,9 +554,8 @@ <h4>Computation steps</h4>
</div>
</li>
<li id="comp_embedded_control">
<span id="step2C"><!-- Don't link to this legacy numbered ID. --></span><em>Embedded Control:</em> Otherwise, if the <code>current node</code> is a control embedded within the label
(e.g. any element directly referenced by <code>aria-labelledby</code>) for another <a class="termref">widget</a>, where the user can adjust the embedded control's value, then return
the embedded control as part of the text alternative in the following manner:
<span id="step2C"><!-- Don't link to this legacy numbered ID. --></span><em>Embedded Control:</em> Otherwise, if the <code>current node</code> is a user-adjustable control embedded
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"user-adjustable" doesn't account for an embedded readonly field.

Do we care about this?

<label for=""cb>
  <input type="cb" name="cb" id="id">
  Flash the screen <input readonly value="3"> times.
</label>

Will the new language, the (admittedly contrived) label above would be " Flash the screen times."

Copy link
Contributor

@cookiecrook cookiecrook Aug 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I guess the old text doesn't account for readonly fields either.

…where the user can adjust the embedded control's value…

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"user-perceivable" perhaps?

Suggested change
<span id="step2C"><!-- Don't link to this legacy numbered ID. --></span><em>Embedded Control:</em> Otherwise, if the <code>current node</code> is a user-adjustable control embedded
<span id="step2C"><!-- Don't link to this legacy numbered ID. --></span><em>Embedded Control:</em> Otherwise, if the <code>current node</code> is a user-perceivable control embedded

Or just remove that adjective?

Copy link
Contributor

@cookiecrook cookiecrook Aug 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: This new proposed language would bring in disabled fields too, but I think that'd be expected if a disabled control were inside a label. What do you all think about this (also contrived) example?

<label for=""cb>
  <input type="cb" name="cb" id="id">
  Flash the screen <input disabled value="3"> times.
</label>

within the label, and the control is not the element being named or described, then return the embedded control's value as part of the text alternative in the following manner:
Copy link
Contributor

@cookiecrook cookiecrook Aug 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: take or leave. "as part of the text alternative" kinda makes it sound like you're overriding how this returned value would be included in the overall text alternative computation... I think the sentence stands without that clause, but feel free to keep it and resolve this comment if you disagree.

Suggested change
within the label, and the control is not the element being named or described, then return the embedded control's value as part of the text alternative in the following manner:
within the label, and the control is not the element being named or described, then return the embedded control's value in the following manner:

<ol>
<li id="comp_embedded_control_textbox"><em>Textbox:</em> If the embedded control has role <a class="role-reference" href="#textbox">textbox</a>, return its value.</li>
<li id="comp_embedded_control_combobox_or_listbox">
Expand Down