Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce associated AudioSession #32

Merged
merged 2 commits into from
Oct 22, 2024
Merged

Conversation

youennf
Copy link
Contributor

@youennf youennf commented Oct 18, 2024

We introduce the 1-1 mapping between Window and navigator.audioSession.


Preview | Diff

index.bs Outdated Show resolved Hide resolved
@@ -134,6 +134,13 @@ This default audio session is represented as an {{AudioSession}} object that is

# Extensions to the `Navigator` interface # {#extensions-to-navigator}

Each {{Window}} has an <dfn>associated AudioSession</dfn>, which is an {{AudioSession}} object.
It represents the default audio session that is used by the user agent to automatically set up the audio session parameters.
The user agent will request or abandon audio focus when audio session [=audio session/elements=] start or finish playing.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to force the implementers to follow this guideline? If so, should we use MUST request or abandon audio focus?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a general description of the intent of the spec. The algorithms will precisely describe how UA is expected to implement this so that all UAs will behave the same.
I do not think that this sentence is precise enough to warrant a MUST.

Copy link
Contributor

@alastor0325 alastor0325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only a small question left. Thanks!

@youennf
Copy link
Contributor Author

youennf commented Oct 22, 2024

I am merging this PR.
About the question related to MUST, I am ok doing a follow-up on this one.
Maybe we can add more wording here or reference the future algorithms.

@youennf youennf merged commit f62ea81 into w3c:main Oct 22, 2024
1 check passed
github-actions bot added a commit that referenced this pull request Oct 22, 2024
SHA: f62ea81
Reason: push, by youennf

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants