Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed texts for initialization, closure of HTTPS and merged signal discovery read with dynamic metadata read on HTTPS parts #485

Merged
merged 4 commits into from
Sep 27, 2023

Conversation

wonsuk73
Copy link
Contributor

@wonsuk73 wonsuk73 commented Sep 5, 2023

  1. This is the draft texts for initialization and closure of session life time management on HTTPS transport protocol
  2. I might need to merge signal discovery read with dynamic metadata read on HTTPS parts. Because it need to make the sync with WebSocket part. In addition Signal discovery read can use the both static metadata and dynamic metadata on the request message.

@wonsuk73 wonsuk73 changed the title Proposed texts for initialization and closure of HTTPS Proposed texts for initialization, closure of HTTPS and merged signal discovery read with dynamic metadata read on HTTPS parts Sep 5, 2023
@tguild
Copy link
Member

tguild commented Sep 5, 2023

Hi @wonsuk73 ,

@UlfBj and I read through your PR and it makes sense with the exception of the sentence about hostname generally having www prefix as that will not be the case when VISS is on a local, in-vehicle network and unlikely as well if remote vehicle connections are allowed.

@wonsuk73
Copy link
Contributor Author

wonsuk73 commented Sep 6, 2023

@tguild and @UlfBj Thanks for valuable comment! I revised texts. Could you review on this? In addition if you have any ideas to enhance the description, please let me know!

@wonsuk73
Copy link
Contributor Author

@tguild, @UlfBj, could you review on revised one?

@UlfBj
Copy link
Contributor

UlfBj commented Sep 27, 2023

@wonsuk73,
The sentence:
A client may send a signal discovery read request to access dynamic metadata.
is in conflict with what is said in the static metadata chapter
https://raw.githack.com/w3c/automotive/gh-pages/spec/VISSv2_Core.html#static-metadata-request
where the term "signal discovery is bound to that type of request.
I propose that this sentence is removed from the PR.
The initialsization/closure parts look fine to me.

@wonsuk73
Copy link
Contributor Author

@UlfBj Thanks for review! I fixed the conflict sentence you mentioned :)

@UlfBj UlfBj merged commit ac6000e into w3c:gh-pages Sep 27, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants